Skip to content

fix: Allow mixing subcommands with subcommand groups#11303

Merged
kodiakhq[bot] merged 2 commits intomainfrom
fix/mixing-subcommands
Nov 30, 2025
Merged

fix: Allow mixing subcommands with subcommand groups#11303
kodiakhq[bot] merged 2 commits intomainfrom
fix/mixing-subcommands

Conversation

@Jiralite
Copy link
Copy Markdown
Member

@Jiralite Jiralite commented Nov 25, 2025

Subcommands may be mixed with subcommand groups at the top level. This pull request allows this and adds a test for it.

Reported: https://canary.discord.com/channels/222078108977594368/937420598383108167/1442986459362627655

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
discord-js-guide Ignored Ignored Preview Nov 30, 2025 4:45pm
discord-js Skipped Skipped Nov 30, 2025 4:45pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.02%. Comparing base (8162ae8) to head (5535888).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11303      +/-   ##
==========================================
+ Coverage   43.66%   45.02%   +1.36%     
==========================================
  Files         375      317      -58     
  Lines       19348    18219    -1129     
  Branches     1884     1820      -64     
==========================================
- Hits         8449     8204     -245     
+ Misses      10886    10002     -884     
  Partials       13       13              
Flag Coverage Δ
builders 81.39% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-project-automation github-project-automation Bot moved this from Todo to Review Approved in discord.js Nov 30, 2025
@vercel vercel Bot temporarily deployed to Preview – discord-js November 30, 2025 16:45 Inactive
@kodiakhq kodiakhq Bot merged commit a57b4d4 into main Nov 30, 2025
27 checks passed
@kodiakhq kodiakhq Bot deleted the fix/mixing-subcommands branch November 30, 2025 16:48
@github-project-automation github-project-automation Bot moved this from Review Approved to Done in discord.js Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants